Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary slight turns #1795

Merged
merged 3 commits into from
Nov 18, 2019
Merged

Conversation

boldtrn
Copy link
Member

@boldtrn boldtrn commented Nov 13, 2019

Fixes #1441. We already had some logic to ignore unnecessary slight turns. I increased the angle to remove more of these examples. This changed the number of instructions in some IT. I had a look at these cases visually and the new version looks better to me. It's a bit hard to do that though, since the test data is quite old, and the map visualization moved on with the current data.

@karussell
Copy link
Member

Thanks!

It's a bit hard to do that though, since the test data is quite old, and the map visualization moved on with the current data.

With the new MVT debug view this is easy :) ?

This changed the number of instructions in some IT.

Do you know why? It seems it changed only the index?

@boldtrn
Copy link
Member Author

boldtrn commented Nov 14, 2019

With the new MVT debug view this is easy :) ?

I thought about that as well :). I didn't use it, probably I should 👍

Do you know why? It seems it changed only the index?

Yes, this is intended. Unnecessary slight turns were removed. Therefore the index of other instructions changed :).

Copy link
Member

@karussell karussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good then!

@karussell karussell added this to the 1.0 milestone Nov 15, 2019
@karussell karussell merged commit d07b5da into graphhopper:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructions: Remove unnecessary slight turns, if the alternative would be a sharp turn
2 participants