Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make day for conditional tag parsing configurable #1817

Merged
merged 3 commits into from
Dec 5, 2019

Conversation

karussell
Copy link
Member

fixes #1815

@karussell karussell added this to the 1.0 milestone Dec 5, 2019
@easbar
Copy link
Member

easbar commented Dec 5, 2019

Cool thanks! The measurement failed with

 Exception in thread "main" java.lang.IllegalStateException: Cannot load properties to fetch EncodingManager configuration at: /ext_data/osm/bayern-190101.osm-gh/
219 	at com.graphhopper.routing.util.EncodingManager.create(EncodingManager.java:110)
220 	at com.graphhopper.GraphHopper.load(GraphHopper.java:742)
221 	at com.graphhopper.GraphHopper.importOrLoad(GraphHopper.java:617)
222 	at com.graphhopper.tools.Measurement.start(Measurement.java:146)
223 	at com.graphhopper.tools.Measurement.main(Measurement.java:67)

... no idea why. Could it be due to the code changes here (changed init() calls or something ?). I think in the measurements we rely on the clean() call in Measurement to remove the gh-folder of previous builds (need to check)

@karussell
Copy link
Member Author

It seems that GraphHopper.init did not initialize the EncodingManager and so this code is entered which tries to create the EncodingManager from the properties file (and fails as the folder does not exist):

https://github.com/graphhopper/graphhopper/blob/master/core/src/main/java/com/graphhopper/GraphHopper.java#L740

@karussell
Copy link
Member Author

Ah, that was my fault :D ... see the change

@@ -34,7 +34,7 @@ mkdir -p ${SINGLE_RESULTS_DIR}
# 1 - small map: node- and edge-based CH + slow routing
java -cp tools/target/graphhopper-tools-*-jar-with-dependencies.jar com.graphhopper.tools.Measurement \
datareader.file=${SMALL_OSM_MAP} \
datareader.date_range_parser_day=2019-11-01
datareader.date_range_parser_day=2019-11-01 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah this happened to me multiple times :(

@easbar
Copy link
Member

easbar commented Dec 5, 2019

Now it worked (even though it shows as failing here, because I canceled one of the two duplicate builds)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make conditional tag parser date configurable
2 participants