Integrate PT #1824
Merged
Integrate PT #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # reader-gtfs/src/main/java/com/graphhopper/reader/gtfs/GraphHopperGtfs.java # reader-osm/src/main/java/com/graphhopper/reader/osm/OSMReader.java
karussell
approved these changes
Dec 12, 2019
| @@ -521,6 +521,7 @@ public GraphHopper init(CmdArgs args) { | |||
| if (!flagEncodersStr.isEmpty() || !encodedValueStr.isEmpty()) { | |||
| if (!encodedValueStr.isEmpty()) | |||
| emBuilder.addAll(tagParserFactory, encodedValueStr); | |||
| registerCustomEncodedValues(emBuilder); | |||
There was a problem hiding this comment.
Ah, this is a bit unfortunate that this is necessary but we would need yet another factory (EncodedValueFactory) plus a method in EncodingManager to support this.
There was a problem hiding this comment.
Yeah, talking about factories, extension points and such is a new issue, or epic. But I don't think it's that bad in this case. "Builder" sounds like something that should be safe to pass around and add stuff to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Functionally integrate PT with rest of GraphHopper, meaning I can put PT into a regular instance that also has other modes, CH etc.
Secondary goal: Also integrate the code a bit.
I still use my own web resources. I just forward requests with
?vehicle=ptto my own resource. (Invisibly. No HTTP redirect, just give Jersey a hint where the request must go.)GraphHopperGtfsis now analogous toGraphHopperOSM(and inherits from it, for better or worse).I needed two extra entry points in
GraphHopper, and I still need to trickGraphHopperin two places: First, I may want to create a Graph completely without an OSM network, so I need to bypass a validation. Second, I need to reset theLocationIndexbecause I need it after importing OSM, but I can only finish it after importing GTFS.In
/info, I need to add PT as an extra mode if we have it, because it doesn't correspond to aFlagEncoder.