Improve turn instructions when leaving the roads #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karussell
approved these changes
Feb 3, 2020
core/src/main/java/com/graphhopper/routing/InstructionsFromEdges.java
Outdated
Show resolved
Hide resolved
Perfect! Thanks for testing this. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1047.
This fixes the two examples given in #1047 and also the new example provided by @karussell.
Let me know what you think about the results? I haven't done too much live testing yet. So feedback would be very welcome.
I also renamed the two edge variable in InstructionsOutgoingEdges again :). I hope the naming is OK? I really struggled with the filteredEdges naming.