highway=path and bicycle=yes should not get speed for pushing section #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karussell
reviewed
Feb 7, 2020
karussell
changed the title
|
There is a difference to bicycle=designated, here we expect 18km/h, which is the cycleway speed. This seems correct to me. If you feel 14km/h is too much for bicycle=yes, what would you suggest? |
For footway and bicycle=yes this is too much IMO. Maybe 10? Or maybe I have the wrong situation in mind. Isn't it like for that sign?
|
|
Yes, the sign is correct. I reduced the speed for this classification to 10 km/h as suggested. |
karussell
approved these changes
Feb 22, 2020
| if (way.hasTag("bicycle", "yes")) | ||
| speed = 10; | ||
| else | ||
| speed = highwaySpeeds.get("cycleway"); |
There was a problem hiding this comment.
For nested if-else blocks can you add the brackets?
|
I added brackets for the nested ifs and improved the identations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://discuss.graphhopper.com/t/bike-profil-highway-pathpath-and-bicycle-yes-should-not-get-speed-for-pushing-section/5148