-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer enable CH by default in GraphHopper class #1914
Conversation
* for any usage of GraphHopper there should either be a setCHEnabled(false) call or some CH profile strings should be set * -> now we can remove it again :)
* remove enabled flag in CH/LMPreparationHandlers
// todonow: do we want the (previously by default) CH profiles here? (same question for all GraphHopperGtfs basically | ||
ghConfig.put("prepare.ch.weightings", "fastest"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaz ? I wasn't sure if CH was used for this test only by accident (because of the default) or if its actually intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like an accident, pt does not use CH -> removed this
reader-gtfs/README.md
Outdated
@@ -17,10 +17,10 @@ wget http://download.geofabrik.de/europe/germany/brandenburg-latest.osm.pbf | |||
# The following process will take roughly 5 minutes on a modern laptop when it is executed for the first time. | |||
# It imports the previously downloaded OSM data of the Brandenburg area as well as the GTFS. | |||
java -Xmx8g -Xms8g \ | |||
# todonow: this is a) outdated, and b) why no CH (when in tests its enabled?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the readme and removed ch.weightings=no
as this is now the default
So far when creating a new
GraphHopper
instance theCHPreparationHandler
was set to be enabled and"fastest"
was used as default weighting, resulting in a"fastest"
CH preparation for every vehicle. In this PR I have removed this default so there no longer are any CH preparations by default. I also removed theLMPreparationHandler#setEnabled
methods, because there are only two cases: Either some CH/LM profiles are configured (then CH/LM is enabled) or not (then CH/LM is disabled), which meanssetEnabled(false)
is equivalent to setting up noCH/LMProfile
s andsetEnabled(true)
requires setting up the profiles and is thus unnecessary.The usage goes like this now: