Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove byteOrder option for Directory, always use little endianess for all DataAccess #2442

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Remove byteOrder option for Directory, always use little endianess for all DataAccess #2442

merged 3 commits into from
Oct 26, 2021

Conversation

easbar
Copy link
Member

@easbar easbar commented Oct 26, 2021

As discussed in #2439

@easbar easbar added this to the 5.0 milestone Oct 26, 2021
@easbar easbar mentioned this pull request Oct 26, 2021
Closed
@easbar
Copy link
Member Author

easbar commented Oct 26, 2021

Switching GHTreeMapComposed to the big bit util does not work. Maybe because of Float.intBitsToFloat? Anyway, this is not related to DataAccess.

@easbar
Merge branch 'master' into always_little_endianess
428dd16 
# Conflicts:
#	core/src/main/java/com/graphhopper/storage/Directory.java
karussell
karussell approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@karussell karussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@easbar easbar merged commit 5a5fe4d into master Oct 26, 2021
@easbar easbar deleted the always_little_endianess branch October 26, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karussell karussell karussell approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@easbar @karussell