Split ways at junctions first #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I changed the handling of OSM ways in OSMReader. This is an updated version of #2424 (since meanwhile we ignore barriers at junctions). Ways are first split at tower nodes and empty sections, then we split loops and later we add barrier edges. This also fixes the issue that we were not able to handle certain types of loop edges. We now split all loops into two pieces except loop segments consisting of only two nodes, which we now ignore. Previously we had to stop adding edges for the current way when we ran into such a case (see #1533, #1525). I checked that the import speed is the same as in master.