Remove CH from GraphHopperStorage, allow delta import of CHs #2481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2388 and #2453.
Our current API to create CH graphs is this:
with the present PR this becomes:
I think this is a big improvement, because we no longer need to setup CHs even before the base graph was built. With this PR and some recent commits it was easy to implement CH delta imports (#2453). The base graph is also no longer coupled to CH.
I'm still not entirely happy with this API, because we still need to call
ghStorage.createCHStorage/Graph
to create the CH structures. This is becauseCHStorage
depends on the number of nodes of the frozen base graph andRoutingCHGraph
needs a reference to theBaseGraph
, which is private and only visible forGraphHopperStorage
. Long-term I actually think we should removeGraphHopperStorage
entirely and makeBaseGraph
public instead, but I'd like to do this in another PR.