Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VehicleTagParser#applyWayTags #2669

Merged
merged 8 commits into from
Oct 5, 2022
Merged

Conversation

easbar
Copy link
Member

@easbar easbar commented Oct 4, 2022

Everything that was possible with this method is still possible using VehicleTagParser#handleWayTags so it is no longer needed. This brings us closer to making the VehicleTagParsers just ordinary TagParsers.

@easbar easbar added this to the 7.0 milestone Oct 4, 2022
@easbar
Copy link
Member Author

easbar commented Oct 4, 2022

The changes in Bike2VehicleTagParser(Test) are of course no longer needed when #2668 is merged first.

Copy link
Member

@karussell karussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@karussell karussell merged commit 51dc8ab into master Oct 5, 2022
@karussell karussell deleted the remove_apply_way_tags branch October 5, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants