Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of node tags like 'highway' or 'crossing' #2705
Make use of node tags like 'highway' or 'crossing' #2705
Changes from 9 commits
ac52a74
1e70c4a
8a09a17
c7d978b
717d1f7
971ac6f
cdbf3ad
6e6cbe9
9324f5a
b5ec43e
f0efbd5
b4d9983
39b8fbf
e764512
dd896ed
adf3ef9
48f3634
8f4cbf1
9d88f1d
0e4f70f
b785cc0
c0e29fa
5bdce99
95f8358
7b22889
f02421a
8287848
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We split barrier nodes into separate (short) edges where both nodes have these barrier tags. The adjacent edges only have one node with these barrier tags and so we need allMatch and anyMatch is not sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do this already one level higher in OSMReader#handleEdge#setArtificialWayTags, something like:
This way the downstream tag parsers can recognize edges that were created by splitting a node by looking at the
gh:split_node_edge
tag and can access the tags of the split node by looking at the node tags for either of the two nodes (they are the same anyway).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do this even earlier: The moment we create the barrier edge we now add the
gh:barrier_edge
tag for the reader way.We could even use the node tags of the split node as value of the
gh:barrier_edge
tag (instead of simplytrue
)? But we can also obtain these tags in the parsers by looking at the node tags of either of the two nodes of these edges, like we currently do, not sure if one would be more clear than the other. We could even do both :)