barrier parser #2901
Open
barrier parser #2901
+124
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easbar
reviewed
Nov 2, 2023
|
|
||
| @Override | ||
| public void handleWayTags(int edgeId, EdgeIntAccess edgeIntAccess, ReaderWay way, IntsRef relationFlags) { | ||
| if (way.hasTag("gh:barrier_edge")) return; |
There was a problem hiding this comment.
Shouldn't this be !way.hasTag(...)? The ways with the gh:barrier_edge are the ones we are interested it, no?
otbutz
suggested changes
Nov 2, 2023
| if (!Helper.isEmpty(barrierStr)) { | ||
| Barrier curr = Barrier.find(barrierStr); | ||
| if (curr == Barrier.MISSING) { | ||
| if (barrierStr.equals("kissing_gate")) barrierVal = Barrier.GATE; |
There was a problem hiding this comment.
These cases should be handled by Barrier.find(). We do something similar in Surface.find()
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add barrier to encoded_values:
Then you can use it in a custom_model and as path detail
See discussion.