Reproducing & fixing reverse speed error #711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug in #665. The work to find this was done in #703.
This bug could be reproduced also for
bike2
which is very strange as I've never seen this failing in 'real world'.The important part now is to set the flags for both speeds explicitly via
or in motorcycle encoder via setSpeed&setReverseSpeed after ferry handling.
This is explicitly mentioned now in the create-new-flagencoder.md guide but the whole process should be made easier later on too.