Io improvements #43
Io improvements #43
Conversation
more effective and cleaner implementation picking
Let readDir append slashes to directory-names
| return name.slice(-1) === '/'; | ||
| } | ||
|
|
||
| _p.readDirRecursive = obtain.factory( |
There was a problem hiding this comment.
I use it in the red-pill to receive all cps file in the cps directory.
There was a problem hiding this comment.
I think it should be an iterator, not a function that might traverse an entire file system.
There was a problem hiding this comment.
There are no iterators yet in ufo js, but I could exclude the method from this module and add it to e.g. metapolator/io/tools as a stand-alone implementation. That way it would not define any API that are hard to get rid of later.
Despite of that, it's meant to traverse the entire file system, if ask for that.
There was a problem hiding this comment.
Traversing the entire FS is fine, but it doesn't seem sensible to do that by buffering an arbitrarily large directory listing in memory, and taking an arbitrarily long time before doing any useful work (especially as this only exacerbates race conditions).
graphicore
force-pushed
the
io-improvements
branch
from
78e2223
to
a471c42
Compare
No description provided.