Address a huge number of TODOs across the codebase (#396)

.changeset/clean-seahorses-develop.md

@@ -0,0 +1,6 @@
+---
+"@dataplan/pg": patch
+---
+
+List and range codecs now use the underlying codec to parse values from
+Postgres.

.changeset/fair-eagles-rescue.md

@@ -0,0 +1,8 @@
+---
+"graphile-build-pg": patch
+"postgraphile": patch
+"@dataplan/pg": patch
+---
+
+pgUnionAll uses a slightly more optimal SQL (where JSON isn't cast to `::text`
+and then back to `::json`)

.changeset/honest-bottles-buy.md

@@ -0,0 +1,5 @@
+---
+"@dataplan/pg": patch
+---
+
+pgUnionAll can now specify a name, making the SQL and query plan easier to read.

.changeset/odd-planes-know.md

@@ -0,0 +1,6 @@
+---
+"grafast": patch
+---
+
+Improve debugging message when new steps are created at a time when doing so is
+forbidden.

.changeset/proud-insects-fetch.md

@@ -0,0 +1,8 @@
+---
+"graphile-build-pg": patch
+"postgraphile": patch
+"@dataplan/pg": patch
+---
+
+Cursor pagination over nullable columns _should_ now work, although it is
+untested.

.changeset/serious-terms-hear.md

@@ -0,0 +1,9 @@
+---
+"graphile-build-pg": patch
+"graphile-utils": patch
+"postgraphile": patch
+"@dataplan/pg": patch
+"grafast": patch
+---
+
+Address a decent number of TODO/FIXME/etc comments in the codebase.

.changeset/tender-eggs-relate.md

@@ -0,0 +1,7 @@
+---
+"graphile-build-pg": patch
+"postgraphile": patch
+"@dataplan/pg": patch
+---
+
+hasNextPage (via hasMore) now uses an access plan rather than a lambda plan.

.changeset/violet-drinks-joke.md

@@ -0,0 +1,7 @@
+---
+"grafast": patch
+---
+
+(Internal) metaByMetaKey is now stored onto the bucket rather than the request
+context, this allows running steps inside special buckets (subscriptions,
+mutations) to run with a clean cache.

.changeset/weak-stingrays-tease.md

@@ -0,0 +1,7 @@
+---
+"graphile-build-pg": patch
+"postgraphile": patch
+"@dataplan/pg": patch
+---
+
+When fetching a single row, an `ORDER BY` clause will no longer be added.

.changeset/wet-snakes-deliver.md

@@ -0,0 +1,10 @@
+---
+"graphile-build-pg": patch
+"@dataplan/pg": patch
+---
+
+Codecs can now (optionally) have executors associated (typically useful for
+record codecs); so we've eradicated runtime resource definition for columns that
+use composite types (or lists thereof) - all composite types accessible from
+attributes are now guaranteed to have a table-like resource generated in the
+registry.

grafast/dataplan-pg/__tests__/mutations/basics/create-relational-post-default-description.deopt.sql

@@ -21,5 +21,4 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;

grafast/dataplan-pg/__tests__/mutations/basics/create-relational-post-default-description.sql

@@ -21,5 +21,4 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;

grafast/dataplan-pg/__tests__/mutations/basics/create-relational-post-no-query.deopt.sql

@@ -24,7 +24,6 @@ lateral (
     ) and (
       __relational_items__."id" = __relational_items_identifiers__."id0"
     )
-  order by __relational_items__."id" asc
 ) as __relational_items_result__;
 
 select __relational_items_result__.*
@@ -41,7 +40,6 @@ lateral (
     ) and (
       __relational_items__."id" = __relational_items_identifiers__."id0"
     )
-  order by __relational_items__."id" asc
 ) as __relational_items_result__;
 
 select __relational_items_result__.*
@@ -58,7 +56,6 @@ lateral (
     ) and (
       __relational_items__."id" = __relational_items_identifiers__."id0"
     )
-  order by __relational_items__."id" asc
 ) as __relational_items_result__;
 
 select __relational_posts_result__.*
@@ -77,7 +74,6 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;
 
 select __relational_posts_result__.*
@@ -96,7 +92,6 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;
 
 insert into interfaces_and_unions.relational_items as __relational_items__ ("type", "author_id") values ($1::interfaces_and_unions.item_type, $2::"int4") returning
@@ -119,7 +114,6 @@ lateral (
     ) and (
       __relational_items__."id" = __relational_items_identifiers__."id0"
     )
-  order by __relational_items__."id" asc
 ) as __relational_items_result__;
 
 select __relational_items_result__.*
@@ -136,7 +130,6 @@ lateral (
     ) and (
       __relational_items__."id" = __relational_items_identifiers__."id0"
     )
-  order by __relational_items__."id" asc
 ) as __relational_items_result__;
 
 select __relational_items_result__.*
@@ -153,7 +146,6 @@ lateral (
     ) and (
       __relational_items__."id" = __relational_items_identifiers__."id0"
     )
-  order by __relational_items__."id" asc
 ) as __relational_items_result__;
 
 select __relational_posts_result__.*
@@ -172,7 +164,6 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;
 
 select __relational_posts_result__.*
@@ -191,7 +182,6 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;
 
 select __relational_posts_result__.*
@@ -210,5 +200,4 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;

grafast/dataplan-pg/__tests__/mutations/basics/create-relational-post-no-query.sql

@@ -24,7 +24,6 @@ lateral (
     ) and (
       __relational_items__."id" = __relational_items_identifiers__."id0"
     )
-  order by __relational_items__."id" asc
 ) as __relational_items_result__;
 
 select __relational_items_result__.*
@@ -41,7 +40,6 @@ lateral (
     ) and (
       __relational_items__."id" = __relational_items_identifiers__."id0"
     )
-  order by __relational_items__."id" asc
 ) as __relational_items_result__;
 
 select __relational_items_result__.*
@@ -58,7 +56,6 @@ lateral (
     ) and (
       __relational_items__."id" = __relational_items_identifiers__."id0"
     )
-  order by __relational_items__."id" asc
 ) as __relational_items_result__;
 
 select __relational_posts_result__.*
@@ -77,7 +74,6 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;
 
 select __relational_posts_result__.*
@@ -96,7 +92,6 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;
 
 insert into interfaces_and_unions.relational_items as __relational_items__ ("type", "author_id") values ($1::interfaces_and_unions.item_type, $2::"int4") returning
@@ -119,7 +114,6 @@ lateral (
     ) and (
       __relational_items__."id" = __relational_items_identifiers__."id0"
     )
-  order by __relational_items__."id" asc
 ) as __relational_items_result__;
 
 select __relational_items_result__.*
@@ -136,7 +130,6 @@ lateral (
     ) and (
       __relational_items__."id" = __relational_items_identifiers__."id0"
     )
-  order by __relational_items__."id" asc
 ) as __relational_items_result__;
 
 select __relational_items_result__.*
@@ -153,7 +146,6 @@ lateral (
     ) and (
       __relational_items__."id" = __relational_items_identifiers__."id0"
     )
-  order by __relational_items__."id" asc
 ) as __relational_items_result__;
 
 select __relational_posts_result__.*
@@ -172,7 +164,6 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;
 
 select __relational_posts_result__.*
@@ -191,7 +182,6 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;
 
 select __relational_posts_result__.*
@@ -210,5 +200,4 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;

grafast/dataplan-pg/__tests__/mutations/basics/create-relational-post-null-description.deopt.sql

@@ -21,5 +21,4 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;

grafast/dataplan-pg/__tests__/mutations/basics/create-relational-post-null-description.sql

@@ -21,5 +21,4 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;

grafast/dataplan-pg/__tests__/mutations/basics/create-relational-post-x4.deopt.sql

@@ -21,7 +21,6 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;
 
 insert into interfaces_and_unions.relational_items as __relational_items__ ("type", "author_id") values ($1::interfaces_and_unions.item_type, $2::"int4") returning
@@ -47,7 +46,6 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;
 
 insert into interfaces_and_unions.relational_items as __relational_items__ ("type", "author_id") values ($1::interfaces_and_unions.item_type, $2::"int4") returning
@@ -73,7 +71,6 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;
 
 insert into interfaces_and_unions.relational_items as __relational_items__ ("type", "author_id") values ($1::interfaces_and_unions.item_type, $2::"int4") returning
@@ -99,5 +96,4 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;

grafast/dataplan-pg/__tests__/mutations/basics/create-relational-post-x4.sql

@@ -21,7 +21,6 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;
 
 insert into interfaces_and_unions.relational_items as __relational_items__ ("type", "author_id") values ($1::interfaces_and_unions.item_type, $2::"int4") returning
@@ -47,7 +46,6 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;
 
 insert into interfaces_and_unions.relational_items as __relational_items__ ("type", "author_id") values ($1::interfaces_and_unions.item_type, $2::"int4") returning
@@ -73,7 +71,6 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;
 
 insert into interfaces_and_unions.relational_items as __relational_items__ ("type", "author_id") values ($1::interfaces_and_unions.item_type, $2::"int4") returning
@@ -99,5 +96,4 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;

grafast/dataplan-pg/__tests__/mutations/basics/create-relational-post.deopt.sql

@@ -28,7 +28,6 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;
 
 select __people_result__.*
@@ -45,5 +44,4 @@ lateral (
     ) and (
       __people__."person_id" = __people_identifiers__."id0"
     )
-  order by __people__."person_id" asc
 ) as __people_result__;

grafast/dataplan-pg/__tests__/mutations/basics/create-relational-post.sql

@@ -31,5 +31,4 @@ lateral (
     ) and (
       __relational_posts__."id" = __relational_posts_identifiers__."id0"
     )
-  order by __relational_posts__."id" asc
 ) as __relational_posts_result__;