Always run the step assertion function [-w]

Fixes #248
graphile · Mar 21, 2023 · fd6eec1 · fd6eec1
1 parent 0ff7e11
commit fd6eec1
Showing 1 changed file with 31 additions and 33 deletions.
diff --git a/grafast/grafast/src/engine/OperationPlan.ts b/grafast/grafast/src/engine/OperationPlan.ts
@@ -1322,45 +1322,43 @@ ${te.join(
         locationDetails,
       });
     } else if (isObjectType(nullableFieldType)) {
-      if (isDev) {
-        // Check that the plan we're dealing with is the one the user declared
-        /** Either an assertion function or a step class */
-        const stepAssertion = nullableFieldType.extensions?.graphile?.Step;
-        if (stepAssertion) {
-          try {
-            if (
-              stepAssertion === ExecutableStep ||
-              stepAssertion.prototype instanceof ExecutableStep
-            ) {
-              if (!($step instanceof stepAssertion)) {
-                throw new Error(
-                  `Step mis-match: expected ${
-                    stepAssertion.name
-                  }, but instead found ${
-                    ($step as ExecutableStep).constructor.name
-                  } (${$step})`,
-                );
-              }
-            } else {
-              (stepAssertion as ($step: ExecutableStep) => void)($step);
+      // Check that the plan we're dealing with is the one the user declared
+      /** Either an assertion function or a step class */
+      const stepAssertion = nullableFieldType.extensions?.graphile?.Step;
+      if (stepAssertion) {
+        try {
+          if (
+            stepAssertion === ExecutableStep ||
+            stepAssertion.prototype instanceof ExecutableStep
+          ) {
+            if (!($step instanceof stepAssertion)) {
+              throw new Error(
+                `Step mis-match: expected ${
+                  stepAssertion.name
+                }, but instead found ${
+                  ($step as ExecutableStep).constructor.name
+                } (${$step})`,
+              );
             }
-          } catch (e) {
-            throw new Error(
-              `The step returned by '${path.join(
-                ".",
-              )}' is not compatible with the GraphQL object type '${
-                nullableFieldType.name
-              }': ${e.message}`,
-              { cause: e },
-            );
+          } else {
+            (stepAssertion as ($step: ExecutableStep) => void)($step);
           }
-        }
-        if (!selections) {
+        } catch (e) {
           throw new Error(
-            `GraphileInternalError<7fe4f7d1-01d2-4f1e-add6-5aa6936938c9>: no selections on a GraphQLObjectType?!`,
+            `The step returned by '${path.join(
+              ".",
+            )}' is not compatible with the GraphQL object type '${
+              nullableFieldType.name
+            }': ${e.message}`,
+            { cause: e },
           );
         }
       }
+      if (!selections) {
+        throw new Error(
+          `GraphileInternalError<7fe4f7d1-01d2-4f1e-add6-5aa6936938c9>: no selections on a GraphQLObjectType?!`,
+        );
+      }
 
       let objectLayerPlan: LayerPlan;
       if (