Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address a huge number of TODOs across the codebase #396

Merged
merged 63 commits into from
Jun 28, 2023
Merged

Address a huge number of TODOs across the codebase #396

merged 63 commits into from
Jun 28, 2023

Commits on Jun 22, 2023

  1. TODO -> NOTE

    @benjie
    benjie committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    71c3bea View commit details
    Browse the repository at this point in the history

  2. Fix parsing of ranges over fancy codecs

    @benjie
    benjie committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    de654cf View commit details
    Browse the repository at this point in the history

  3. Remove a PgResource.configFromCodec call

    @benjie
    benjie committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    77c03df View commit details
    Browse the repository at this point in the history

  4. Move resource generation to build time, give codecs executors

    @benjie
    benjie committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    ec53f4b View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Address a TODO

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    d5de1a4 View commit details
    Browse the repository at this point in the history

  2. Move codec-based resource generation to registry construction time

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    db3aa6e View commit details
    Browse the repository at this point in the history

  3. Do not generate schema entities based on virtual codec resources

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    e5168d7 View commit details
    Browse the repository at this point in the history

  4. Update snapshots with new resource names

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    ffb9303 View commit details
    Browse the repository at this point in the history

  5. Lint

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    9398a10 View commit details
    Browse the repository at this point in the history

  6. Remove another TODO

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    d67b3df View commit details
    Browse the repository at this point in the history

  7. Remove some TODOs

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    01462e3 View commit details
    Browse the repository at this point in the history

  8. Customize error to remove a TODO

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    776a4ef View commit details
    Browse the repository at this point in the history

  9. Optimize hasMore on pgSelect 

    I did some benchmarking and `Object.defineProperty` on a list slows
iteration by a third, but just setting the property normally
(`arr.hasMore = true`) has negligible impact on iteration performance.

Further, I've made it so the property is only set when the list does
indeed have more, so more cases should be optimized.
    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    1e75674 View commit details
    Browse the repository at this point in the history

  10. Update plans from Lambda to Access

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    6f111ec View commit details
    Browse the repository at this point in the history

  11. Add cleaner hasMore approach to union too

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    e5b58ed View commit details
    Browse the repository at this point in the history

  12. Make union more unique by using an (optional) name

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    e8ce023 View commit details
    Browse the repository at this point in the history

  13. Update snapshots with new cursors and aliases

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    4a2ccb1 View commit details
    Browse the repository at this point in the history

  14. Don't cast to text then back to json

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    9c2a6c5 View commit details
    Browse the repository at this point in the history

  15. alreadyEncoded not needed for pgSelect

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    b5b6431 View commit details
    Browse the repository at this point in the history

  16. Validate column types align when ordering on union

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    0b2e2b6 View commit details
    Browse the repository at this point in the history

  17. Handle nullability in ordering

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    7615022 View commit details
    Browse the repository at this point in the history

  18. Copy nullable ordering logic over to pgSelect

    @benjie
    benjie committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    6828fd2 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Indeed, it is not needed.

    @benjie
    benjie committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    cea2f69 View commit details
    Browse the repository at this point in the history

  2. Codecs should throw if data is invalid

    @benjie
    benjie committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    f1caff6 View commit details
    Browse the repository at this point in the history

  3. Write manual async generator to enable early return/throw

    @benjie
    benjie committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    104c852 View commit details
    Browse the repository at this point in the history

  4. Demote TODO to PERF

    @benjie
    benjie committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    2029673 View commit details
    Browse the repository at this point in the history

  5. Add more consistency checks

    @benjie
    benjie committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    e7fa19d View commit details
    Browse the repository at this point in the history

  6. Fix hack using new logic

    @benjie
    benjie committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    b1b6610 View commit details
    Browse the repository at this point in the history

  7. Don't order queries when they are unique

    @benjie
    benjie committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    5227e72 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Fix mutation edge cursors

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    7df1972 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary order by clauses

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    495428a View commit details
    Browse the repository at this point in the history

  3. Remove redundant codec

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    cfb5afd View commit details
    Browse the repository at this point in the history

  4. Demote TODO to PERF

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    2c09556 View commit details
    Browse the repository at this point in the history

  5. Assert that hookArgs is only called once

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    f6538af View commit details
    Browse the repository at this point in the history

  6. Centralize hasItemPlan

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    2974ab1 View commit details
    Browse the repository at this point in the history

  7. Demote TODO to TYPES

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    dda79bd View commit details
    Browse the repository at this point in the history

  8. Move TODO to LOGGING

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    bc0eedb View commit details
    Browse the repository at this point in the history

  9. Remove commented code

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    d977878 View commit details
    Browse the repository at this point in the history

  10. TODO -> LOGGING

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    fca675d View commit details
    Browse the repository at this point in the history

  11. Expand TODO with more details

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    c7527bc View commit details
    Browse the repository at this point in the history

  12. Remove a FIXME, assert that it has already been handled

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    e09a48a View commit details
    Browse the repository at this point in the history

  13. Lint

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    77c1e69 View commit details
    Browse the repository at this point in the history

  14. Forbid creating steps during deduplicate

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    48b5ccd View commit details
    Browse the repository at this point in the history

  15. Already renamed?

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    07ccf9b View commit details
    Browse the repository at this point in the history

  16. Move from 'HACK' to 'TEST' with longer explanation

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    a43a663 View commit details
    Browse the repository at this point in the history

  17. Creating new steps during deduplicate is explicitly not forbidden

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    1ce565a View commit details
    Browse the repository at this point in the history

  18. Tidyup is more of a performance concern

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    55e95f8 View commit details
    Browse the repository at this point in the history

  19. Not sure about this, leave it as a note

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    60c7a6c View commit details
    Browse the repository at this point in the history

  20. Move metaByMetaKey to live on bucket rather than requestContext

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    14988a0 View commit details
    Browse the repository at this point in the history

  21. Lint

    @benjie
    benjie committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    f0cd550 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. https://github.com/benjie/postgraphile-private/issues/395

    @benjie
    benjie committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    00ec6af View commit details
    Browse the repository at this point in the history

  2. No action necessary right now

    @benjie
    benjie committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    c1adcdf View commit details
    Browse the repository at this point in the history

  3. Reclassify some TODOs

    @benjie
    benjie committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    8587b57 View commit details
    Browse the repository at this point in the history

  4. docs(changeset): Codecs can now (optionally) have executors associate… 

    …d (typically useful for record codecs); so we've eradicated runtime resource definition for columns that use composite types (or lists thereof) - all composite types accessible from attributes are now guaranteed to have a table-like resource generated in the registry.
    @benjie
    benjie committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    9f2507e View commit details
    Browse the repository at this point in the history

  5. docs(changeset): List and range codecs now use the underlying codec t… 

    …o parse values from Postgres.
    @benjie
    benjie committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    6595083 View commit details
    Browse the repository at this point in the history

  6. docs(changeset): pgUnionAll can now specify a name, making the SQL an… 

    …d query plan easier to read.
    @benjie
    benjie committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    56b5229 View commit details
    Browse the repository at this point in the history

  7. docs(changeset): Cursor pagination over nullable columns _should_ now… 

    … work, although it is untested.
    @benjie
    benjie committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    b5eb7c4 View commit details
    Browse the repository at this point in the history

  8. docs(changeset): hasNextPage (via hasMore) now uses an access plan ra… 

    …ther than a lambda plan.
    @benjie
    benjie committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    b66d250 View commit details
    Browse the repository at this point in the history

  9. docs(changeset): When fetching a single row, an ORDER BY clause wil… 

    …l no longer be added.
    @benjie
    benjie committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    3caaced View commit details
    Browse the repository at this point in the history

  10. docs(changeset): pgUnionAll uses a slightly more optimal SQL (where J… 

    …SON isn't cast to `::text` and then back to `::json`)
    @benjie
    benjie committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    17fe531 View commit details
    Browse the repository at this point in the history

  11. docs(changeset): (Internal) metaByMetaKey is now stored onto the buck… 

    …et rather than the request context, this allows running steps inside special buckets (subscriptions, mutations) to run with a clean cache.
    @benjie
    benjie committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    e8c81cd View commit details
    Browse the repository at this point in the history

  12. docs(changeset): Improve debugging message when new steps are created… 

    … at a time when doing so is forbidden.
    @benjie
    benjie committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    9feb769 View commit details
    Browse the repository at this point in the history

  13. docs(changeset): Address a decent number of TODO/FIXME/etc comments i… 

    …n the codebase.
    @benjie
    benjie committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    7573bf3 View commit details
    Browse the repository at this point in the history