Fix bug in postgraphile CLI parser for no --watch
#1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… force `watch: false` even if config sets `watch: true`.
🦋 Changeset detectedLatest commit: 0048892 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CLI flags override the config; so if you have
watch: falsein the config but run the CLI withpostgraphile --watchthen watch mode should be enabled. However because we haddefault: falsein the config for the argument parser, we were overridingwatch: truein the config withwatch: falsefrom the CLI.Removing this default resolves the issue.
Issue raised by @TimoStolz via Discord: (sponsors only channel): https://discord.com/channels/489127045289476126/953710447087980654/1176875333560062145
Performance impact
None.
Security impact
None.
Checklist
yarn lint:fixpasses.I've added tests for the new feature, andyarn testpasses.I have detailed the new feature in the relevant documentation.RELEASE_NOTES.mdfile (if one exists).