Move PgContextPlugin into @dataplan/pg #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 13be850 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…taplan/pg so it can be used after schema export without needing dependency on graphile-build-pg
benjie
force-pushed
the
move-pgcontextplugin
branch
from
0f3168d
to
7064ff1
Compare
benjie
force-pushed
the
move-pgcontextplugin
branch
from
92b21db
to
13be850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you export your schema, you should still be able to use the
withPgClient/pgSettings/etc on the GraphQL context. This is currently handled viaPgContextPlugin, but if you import that from graphile-build-pg then you have to bundle all of graphile-build-pg and graphile-build into your serverless schema bundle... which sucks!Solution: move this plugin into
@dataplan/pg(which you'll need at runtime anyway) so your production config can pull in just this one plugin and not the entirity of graphile-build.Performance impact
Improves bundled exported schemas by reducing dependencies, reducing parsing time and memory usage, and improving startup speed.
Security impact
None known.
Checklist
yarn lint:fixpasses.yarn testpasses.I have detailed the new feature in the relevant documentation.RELEASE_NOTES.mdfile (if one exists).If this is a breaking change I've explained why.