Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RBAC permission detection for tables #1894

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Fix RBAC permission detection for tables #1894

merged 7 commits into from
Dec 18, 2023

Conversation

benjie
Copy link
Member

@benjie benjie commented Dec 18, 2023

Description

Looks like there was some older code hanging around which had faulty logic (in particular, it granted NO PERMISSIONS to the owner of a table by default ?!); we already have a chain of logic that matches the Postgres source so we've deleted aclsForTable and used the shared logic instead.

I've also taken the time to make the code closer to the postgres source to make auditing easier.

Performance impact

Marginal, gather/build phase only.

Security impact

Exposes more resources (because it's more correct).

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: 7346552

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
pg-introspection Patch
postgraphile Patch
graphile-build-pg Patch
pgl Patch
graphile-utils Patch
graphile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit c04e6e9 into main Dec 18, 2023
24 checks passed
@benjie benjie deleted the fix-rbac branch December 18, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant