Fix RBAC permission detection for tables #1894
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like there was some older code hanging around which had faulty logic (in particular, it granted NO PERMISSIONS to the owner of a table by default ?!); we already have a chain of logic that matches the Postgres source so we've deleted
aclsForTable
and used the shared logic instead.I've also taken the time to make the code closer to the postgres source to make auditing easier.
Performance impact
Marginal, gather/build phase only.
Security impact
Exposes more resources (because it's more correct).
Checklist
yarn lint:fix
passes.yarn test
passes.RELEASE_NOTES.md
file (if one exists).