Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new API for determining the codec to use for a Postgres type #1949

Merged
merged 16 commits into from
Feb 7, 2024

Conversation

benjie
Copy link
Member

@benjie benjie commented Feb 7, 2024

Description

New pgCodecs_findPgCodec hook enables searching for the PgCodec to use for a specific PgType - this enables users to add their own codecs for their own custom types (not requiring them to be added to core). This is demonstrated via PgLtreePlugin which adds the LTree GraphQL type for use with the ltree database type.

Whilst working on this, I also:

  • Fixed issue with jsonwebtoken in the test script
  • Improved some error messages
  • Made it so plugins don't need to declare a namespace just to use cache/state
  • Stripped oids from the test exports to reduce the diff on CI/etc

This PR:

Performance impact

Marginal impact on gather phase; runtime should not be impacted.

Security impact

None known.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Feb 7, 2024

🦋 Changeset detected

Latest commit: d03c7d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
graphile-build-pg Patch
graphile-build Patch
postgraphile Patch
graphile-utils Patch
pgl Patch
graphile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit 155f2f5 into main Feb 7, 2024
24 checks passed
@benjie benjie deleted the ltree branch February 7, 2024 16:01
@benjie benjie mentioned this pull request May 9, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
1 participant