Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXPORTABLE now supports name hints #1958

Merged
merged 14 commits into from
Feb 12, 2024
Merged

EXPORTABLE now supports name hints #1958

merged 14 commits into from
Feb 12, 2024

Conversation

benjie
Copy link
Member

@benjie benjie commented Feb 12, 2024

Description

  • Add third argument to EXPORTABLE.
  • Use this argument in a few places.
  • Fix graphile-export optimize function so it re-evaluates scope (by stringifying and re-parsing), fixing some inlining issues
  • Tidy up a number of the exports by using these two new features
  • Convert foo(...["a", "b]) to foo("a", "b") automatically

Performance impact

Exports are probably slower (but better).

Security impact

None known.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Feb 12, 2024

🦋 Changeset detected

Latest commit: 0404b5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
graphile-build-pg Patch
graphile-build Patch
graphile-utils Patch
postgraphile Patch
graphile-export Patch
@dataplan/pg Patch
grafast Patch
tamedevil Patch
pgl Patch
graphile Patch
@localrepo/grafast-bench Patch
@dataplan/json Patch
@grafserv/persisted Patch
grafserv Patch
ruru-components Patch
@localrepo/grafast-website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie marked this pull request as ready for review February 12, 2024 09:06
@benjie benjie merged commit aa1b7d1 into main Feb 12, 2024
24 checks passed
@benjie benjie deleted the name-hint branch February 12, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant