Fix parsing of record codecs that have attributes with castFromPg #1988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1987. Essentially it wasn't safe to do
record::text
if any of the codecs of the attributes of the record usedcastFromPg
because theirfromPg
methods would be expecting the cast version of the data, not the raw data. Solution was to check forcastFromPg
on each attribute and then cast the entire expression if one existed.Performance impact
Yikes.
Security impact
Improvement?
Checklist
yarn lint:fix
passes.yarn test
passes.I have detailed the new feature in the relevant documentation.RELEASE_NOTES.md
file (if one exists).