Fix detection of pgSelect allowing merging #1989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1987 was only an issue because the function wasn't optimized and was being called via a second SQL query. This was undesirable. It turns out to be due to the dependency checking in
pgSelect
'soptimize
method. Really we just want to know that the dependencies can be pushed onto the new parent... so I've rewritten the code to do this instead.Performance impact
Significant improvement in some cases.
Security impact
Helps avoid DOS I guess?
Checklist
yarn lint:fix
passes.yarn test
passes.I have detailed the new feature in the relevant documentation.RELEASE_NOTES.md
file (if one exists).