Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of pgSelect allowing merging #1989

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Conversation

benjie
Copy link
Member

@benjie benjie commented Mar 13, 2024

Description

#1987 was only an issue because the function wasn't optimized and was being called via a second SQL query. This was undesirable. It turns out to be due to the dependency checking in pgSelect's optimize method. Really we just want to know that the dependencies can be pushed onto the new parent... so I've rewritten the code to do this instead.

Performance impact

Significant improvement in some cases.

Security impact

Helps avoid DOS I guess?

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Mar 13, 2024

🦋 Changeset detected

Latest commit: c48d3da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
grafast Patch
postgraphile Patch
@dataplan/pg Patch
@localrepo/grafast-bench Patch
@dataplan/json Patch
@grafserv/persisted Patch
grafserv Patch
ruru-components Patch
@localrepo/grafast-website Patch
graphile-build-pg Patch
graphile-build Patch
graphile-utils Patch
pgl Patch
graphile-export Patch
graphile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit ec1d13d into main Mar 13, 2024
24 checks passed
@benjie benjie deleted the optimize-more-pgSelect branch March 13, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant