Various major fixes to schema exporting #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2a00087 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…g it in place (fix enums)
… additional properties set, and makes sure these properties are exported too. (Typically this is `fn.isSyncAndSafe=true` for Grafast optimization.)
…d for input objects.
benjie
force-pushed
the
schema-exports-test
branch
from
c180f80
to
420301b
Compare
…with enums and more.
…BLE) to fix schema exports.
…fer`/`@stream` directives are present.
benjie
commented
May 7, 2024
| @@ -12373,6 +12389,15 @@ const makeArgs64 = (args, path = []) => { | |||
| return selectArgs; | |||
| }; | |||
| const resource_compound_type_computed_fieldPgResource = registry.pgResources["compound_type_computed_field"]; | |||
| function UUIDSerialize(value) { | |||
| return "" + value; | |||
| } | |||
There was a problem hiding this comment.
As an optimization we should have this export as toString (the source name) rather than being called UUIDSerialize everywhere. But no big deal.
benjie
commented
May 7, 2024
Comment on lines
33442
to
+33445
| NestedCompoundTypeInput: { | ||
| "__inputPlan": function NestedCompoundTypeInput_inputPlan() { | ||
| return object(Object.create(null)); | ||
| }, |
There was a problem hiding this comment.
Would be nice to optimize this down to a method syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets up testing of the exported schemas by running the integration tests again, this time by generating the schema (as before) then exporting the schema, importing it, and using the imported version for running the tests. It's really inefficient right now, making the tests really slow, but worth it for peace of mind. In future this will need to be redeveloped to find all the schema configurations and then write out those schemas in advance and use them to run the tests against.
Then, of course, there were loads of hard to figure out errors/discrepancies which I had to track down. Roughly:
grafast'smakeGrafastSchemahas been rebuilt to follow better patterns (fixing issues with enums in the process)grafast'smakeGrafastSchemanow supports__inputPlan(){}on an input object's plansgraphile-exportnow exports the input object input plan intypeDefsmodegraphile-exportnow detects functions with additional properties (e.g.isSyncAndSafe: true) and makes sure these properties are represented in the exportgraphile-exportnow outputs theserialize,parseValueandparseLiteralmethods on custom scalars intypeDefsmodeEXPORTABLEto fix exportsEXPORTABLEfrom a couple of things to fix exportsConstantStepnow supports.get()and.at()patternsenableDeferStreamdetection in schema export by looking at directives in schema being exportedFixes #2043
Fixes #2049
Performance impact
Import/export only.
Security impact
Improvement: more accurate exports are safer.
Checklist
yarn lint:fixpasses.yarn testpasses.RELEASE_NOTES.mdfile (if one exists).