Add missing type coercion in computed procedure field #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Merge when it passes CI |
Belline
pushed a commit
to Belline/postgraphql
that referenced
this pull request
Dec 18, 2017
…ld (graphile#409) * run all of the integration tests in parallel * move test utilities * only introspect catalog once * speed up some tests * set a max workers count * add a thing * remove a thing to trigger build * fix lint errors * fix integration queries with different configurations * only test Koa in versions of Node.js greater than 4 * fix values not getting properly coerced * Update snapshots after merge
benjie
added a commit
that referenced
this pull request
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #390
This PR builds off of #408 because I wanted the tests to be faster as I fixed this issue 😊
Here is the diff that actually fixes the issue: 0297398
Specifically this line: 0297398#diff-68e6e47f66f4641b59bfbd00beff36acR62
When doing the types refactor I forgot to add a coercion at that point from the Postgres value to the internal PostGraphQL value 😣. This PR makes sure that coercion happens. I’m surprised there was no test case for this, so a test case has also been added.