fix(postgres): cast list of enums to their correct type (#417)

[danielbuechele]

This adds an explicit type cast to enum arrays

Fixes #417

[benjie]

Thanks @danielbuechele, this is a much requested feature!

I'm not confident in the sql.raw with the notNullType.name; can we use sql.identifier here instead? Something like

const listTypeCast = sql.query(`::${sql.identifier(nonNullType instanceof PgEnumType ? nonNullType.name : 'text')}[]`)

I'm not sure if that will work?

[danielbuechele]

Now using sql.identifier. Also changed it to work not only with enums but custom classes, too.

[benjie]

This looks great @danielbuechele! Are you able to add any tests for it?

[benjie]

I'm not comfortable merging this until there are some tests in place (because I don't understand enough of PostGraphQL to be certain this won't cause any issues).

[danielbuechele]

Added test for the function I modified

[danscan]

@benjie @danielbuechele What is the status of this? Looks like it's just blocked by some tests. I can add these if that'd be helpful.

[benjie]

@danscan I think we just need CI to pass before we can merge.

[benjie]

It seems to just be lint issues that need resolving.

[danielbuechele]

I'll fix them tomorrow! (and get my linter working)

[danielbuechele]

Huh, linter is now passing, but a lot of other test failing. I don't really know where this is coming from.

[benjie]

The errors centre around:

GraphQLError: function c.types_mutation(unknown, unknown, unknown, text[], unknown, numrange) does not exist
GraphQLError: function c.types_query(unknown, unknown, unknown, text[], unknown, numrange) does not exist

Here's the relevant definitions:

https://github.com/postgraphql/postgraphql/blob/886f8752f03d3fa05bdbdd97eeabb153a4d0343e/examples/kitchen-sink/schema.sql#L155-L156

Seems the integer array is being interpreted as a text array instead.

[benjie]

[semi-automated message] Hi, there has been no activity in this issue for over 8 weeks so I'm closing it to keep the issues/pull request manageable. If this is still an issue, please re-open with a comment explaining why.