Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUMERIC function parameters: Float! => String! #127

Closed
stlbucket opened this issue Dec 4, 2017 · 3 comments
Closed

NUMERIC function parameters: Float! => String! #127

stlbucket opened this issue Dec 4, 2017 · 3 comments
Milestone

Comments

@stlbucket
Copy link

stlbucket commented Dec 4, 2017

did numeric fields begin expressing as String! in the schema? today i upgraded from 4.0.0-alpha2.24 to 4.0.0-alpha2.26 so that i could add this library: https://github.com/mattbretl/postgraphile-plugin-connection-filter

at this point my graphQL mutations all now expect String! where previously they expected Float! when my function parameter type is NUMERIC.

unfortunately, if I try to rollback to 2.24, the problem is still there, so it seems that maybe this postgraphile is not the problem.

but maybe i had an old dependence or something?

@stlbucket
Copy link
Author

image

I am not 100% sure if this is the line of code that sets this mapping, but makes sense.

@stlbucket
Copy link
Author

instead, this is the line of code controlling this:

image

@benjie
Copy link
Member

benjie commented Dec 5, 2017

Yes, please track graphile/crystal#506 for breaking change announcements during the alpha - I comment with every release that introduces breaking changes.

See also: #123

@benjie benjie closed this as completed Dec 5, 2017
@benjie benjie added this to the 4.0 milestone Aug 16, 2018
madtibo pushed a commit to spacefill/graphile-engine that referenced this issue Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants