Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Fix dependency patterns, graphql compatibility #172

Merged
merged 8 commits into from
Feb 23, 2018
Merged

Conversation

benjie
Copy link
Member

@benjie benjie commented Feb 21, 2018

Updates to newer GraphQL library - now uses """ for comments rather than #.

Also fixes an issue where the system doesn't correctly skip the Mutation type if there's no mutations.

@benjie
Copy link
Member Author

benjie commented Feb 22, 2018

The only reason this is passing is because Flow isn't running across the packages. There's hundreds of errors once running across packages is enabled.

@benjie
Copy link
Member Author

benjie commented Feb 23, 2018

Fixing Flow is going to take too long and delay v4 too much. I'm going to merge without and we can go through and add flow to everything when we refactor later.

@benjie benjie merged commit 0c4f9a5 into master Feb 23, 2018
@benjie benjie deleted the fixes branch February 23, 2018 11:48
madtibo pushed a commit to spacefill/graphile-engine that referenced this pull request Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant