New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): minor TypeScript fixes #545

Merged

benjie merged 1 commit into graphile:master from bensalilijames:bhsj/minor-ts-fixes

Oct 23, 2019

Contributor

bensalilijames commented Oct 18, 2019

Two tweaks:

ExtensionDefinition.resolvers should be optional, as seen in the docs here, and verified that this change is OK to make at the call site here as there is a default empty object
QueryBuidler.orderBy should have ascending and nullsFirst as optional, as seen also in the docs here, and verified that this change is OK to make at the call site here


          Minor TypeScript fixes

4bdcc31

benjie approved these changes

View reviewed changes

Member

benjie left a comment

Excellent pull request; thank you! 🙌

benjie changed the title ~~Minor TypeScript fixes~~ fix(types): minor TypeScript fixes

benjie merged commit 0170064 into graphile:master

benjie mentioned this pull request

[Snyk] Security upgrade semver from 6.3.0 to 7.5.2 #837

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment