Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Add Typical Charting Truncations #21

Closed
wants to merge 3 commits into from

Conversation

jeremybradbury
Copy link

@jeremybradbury jeremybradbury commented Aug 5, 2021

Description

Hour & Day are nice, but groups by Year, Quarter, Month & Week have common reporting and charting uses. This plugin is meant to extend the core into a tool for reporting and charting it even includes standard deviation calculations.

See #20 for more.

TLDR: writing a plugin to extend this plugin using JS fails when combining with the having clauses.

I'll be keeping this fork up to date and relying on it until/unless this is merged or I find a way to hook into another appendPlugin properly.

Performance impact

Zero performance impact, only adding lower cost aggregations.

Security impact

Zero security impact, only adding more options to an existing enum. The existing risk from the attack vector of "hour" being included, is greater than anything I've added here. I even considered removing it, but instead left a comment to point out the not-so-obvious security/cost hole of having it included by default.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant