WIP - Add Typical Charting Truncations #21
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hour & Day are nice, but groups by Year, Quarter, Month & Week have common reporting and charting uses. This plugin is meant to extend the core into a tool for reporting and charting it even includes standard deviation calculations.
See #20 for more.
TLDR: writing a plugin to extend this plugin using JS fails when combining with the having clauses.
I'll be keeping this fork up to date and relying on it until/unless this is merged or I find a way to hook into another appendPlugin properly.
Performance impact
Zero performance impact, only adding lower cost aggregations.
Security impact
Zero security impact, only adding more options to an existing enum. The existing risk from the attack vector of "hour" being included, is greater than anything I've added here. I even considered removing it, but instead left a comment to point out the not-so-obvious security/cost hole of having it included by default.
Checklist
yarn lint:fix
passes.yarn test
passes.RELEASE_NOTES.md
file (if one exists).