Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(http2): basic HTTP2 support for event-stream #1009

Merged
merged 10 commits into from
Feb 28, 2019
Merged

feat(http2): basic HTTP2 support for event-stream #1009

merged 10 commits into from
Feb 28, 2019

Conversation

benjie
Copy link
Member

@benjie benjie commented Feb 27, 2019 •
edited
Loading

Fixes #994

This PR that took me many hours:

  • disables one line of code when in HTTP2 mode (namely: res.setHeader('Connection', 'keep-alive');)
  • includes a fork of supertest that sort-of supports superagent v4 which supports http2
  • hopefully doesn't introduce any bugs into the tests
  • was a pain in the butt.

@benjie benjie mentioned this pull request Feb 27, 2019
Closed
@benjie benjie merged commit 3ebea16 into master Feb 28, 2019
@benjie benjie deleted the http2 branch February 28, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benjie