Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarn server schema:export command via makeSchema #357

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

jamesallain
Copy link
Collaborator

Description

Fix schema-export. I had to change the script to run it. cross-env wasn't working for me.

Performance impact

none

Security impact

unknown

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

@jamesallain
Copy link
Collaborator Author

I think it's failing where You must set the I_SPONSOR_GRAPHILE environmental variable to the shared secret to use this pre-release software.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, apparently this file doesn't get type checked with everything else!

@benjie benjie changed the title fixed file schema-export. Using makeSchema now. Fix yarn server schema:export command via makeSchema Mar 17, 2023
@benjie benjie merged commit 61febc6 into graphile:v5 Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants