Fixed standard output from child process (#472)

graphile · Jun 12, 2024 · e57fd71 · e57fd71
2 parents 572ebea + ccea269
commit e57fd71
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -27,6 +27,8 @@ Read more:
   using it!
 - Fixes bug where CLI defaults override `graphile.config.js` settings (by
   removing CLI defaults)
+- Fix bug where executable tasks had their stdout/stderr ignored; this is now
+  output via logging (thanks @wineTGH).
 
 ## v0.16.6
 

diff --git a/src/plugins/LoadTaskFromExecutableFilePlugin.ts b/src/plugins/LoadTaskFromExecutableFilePlugin.ts
@@ -87,10 +87,10 @@ function makeTaskForExecutable(taskIdentifier: string, fullPath: string): Task {
       child.once("error", (error) => {
         reject(error);
       });
-      child.on("stdout", (data) => {
+      child.stdout.on("data", (data) => {
         helpers.logger.info(data.toString("utf8"));
       });
-      child.on("stderr", (data) => {
+      child.stderr.on("data", (data) => {
         helpers.logger.error(data.toString("utf8"));
       });
       child.once("close", (code) => {