Internal refactor of cron #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was performed to prepare for graphile#219. No new functionality was implemented as part of this commit.
wokalski
force-pushed
the
cron-pattern-internal-refactor
branch
from
23604f0
to
4fcaeca
Compare
5 tasks
benjie
requested changes
Mar 7, 2022
src/cronMatcher.ts
Outdated
|
|
||
| /** | ||
| * Returns true if the cronItem should fire for the given timestamp digest, | ||
| * false otherwise. | ||
| */ | ||
| export function cronItemMatches( | ||
| cronItem: ParsedCronItem, | ||
| cronItem: CrontabRanges, |
There was a problem hiding this comment.
Note to self: this is not a breaking change.
|
hey @benjie can we get this merged? I'll sort out the CI but still needs an approval |
benjie
requested changes
Apr 7, 2022
|
|
||
| export const parseCronRangeString = ( | ||
| pattern: string, | ||
| source: string = "", |
There was a problem hiding this comment.
We should only add in ${source} if there is a source; so either remove the = "" here or handle the source missing in the error message and make sure parseCrontabRanges is also happy with no source.
Suggested change
| source: string = "", | |
| source: string, |
| } | ||
| const { minutes, hours, dates, months, dows } = parseCrontabRanges( | ||
| matches, | ||
| const { minutes, hours, dates, months, dows } = parseCronString( |
There was a problem hiding this comment.
Should this be parseCronRangeString?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was performed to prepare for proper implementation of #218. No new functionality was
implemented as part of this commit. I will rebase #219 on top of this so that the diff for the new feature is smaller.
Performance impact
should be none
Security impact
unknown
Checklist
yarn lint:fixpasses.yarn testpasses.`