homogenize object cols to str #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmeyerov
approved these changes
Mar 20, 2024
…phistry into fix/hetero_feat
lmeyerov
reviewed
Mar 20, 2024
graphistry/feature_utils.py
Outdated
| @@ -907,6 +907,7 @@ def process_dirty_dataframes( | |||
| try: | |||
| X_enc = data_encoder.fit_transform(ndf, y) | |||
| except TypeError: | |||
| logger.info("obj columns:", object_columns, "are being converted to str") | |||
There was a problem hiding this comment.
@dcolinmorgan logger.info("obj columns: %s are being converted to str", object_columns)
There was a problem hiding this comment.
message was placed before object_columns was defined
lmeyerov
approved these changes
Mar 20, 2024
lmeyerov
reviewed
Mar 23, 2024
| object_columns = nndf.select_dtypes(include=['object']).columns | ||
| nndf[object_columns] = nndf[object_columns].astype(str) | ||
| X_enc = data_encoder.fit_transform(nndf, y) | ||
| logger.info("obj columns: %s are being converted to str", object_columns) |
There was a problem hiding this comment.
can we get a test that triggers & handles this edge case?
can land after, looks good!
lmeyerov
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g.umap() works even after adding this column to the untitled.json data