Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If MAX_CREATES_PER_MINUTE is <60, no new metrics are created #55

Closed
jeblair opened this issue Dec 29, 2012 · 2 comments
Closed

If MAX_CREATES_PER_MINUTE is <60, no new metrics are created #55

jeblair opened this issue Dec 29, 2012 · 2 comments

Comments

@jeblair
Copy link

jeblair commented Dec 29, 2012

In the 0.9.x branch, division is performed on an integer:

fill_rate = settings.MAX_CREATES_PER_MINUTE / 60

So if it's less than 60, the fill rate is 0, and no new metrics are created after the initial MAX is hit.

The example carbon.conf suggests a value of 50, so new users are likely to encounter this.
jeblair added a commit to jeblair/carbon that referenced this issue Dec 29, 2012
@jeblair
Treat MAX_CREATES_PER_MINUTE as a float.
d04235d 
The MAX value is an integer, but was being divided by 60, and so
was producing an integer result.  Therefore, if MAX was < 60,
the result is 0 and no new metrics are created after the initial
MAX is hit.  If MAX is >= 60, new metrics will be created, though
not at exactly the rate that would be expected.

The TokenBucket expects floating point values, so force the
division to be floating point.

Fixes issue graphite-project#55.
@jeblair jeblair mentioned this issue Dec 29, 2012
Merged
@michaelmaring
Copy link

conf/carbon.conf:MAX_CREATES_PER_MINUTE = 50

@obfuscurity
Copy link
Member

This was fixed in #56, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@obfuscurity @jeblair @michaelmaring