Add new type of cache query - 'cache-query-bulk' #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or datapoints of a set of metrics, which gives much better performance than single request per metric.
mleinart
added a commit
that referenced
this pull request
Aug 21, 2013
Add new type of cache query - 'cache-query-bulk'
|
Thanks, I like this. I've merged it in with one change: rather than ignoring MAX_LENGTH errors, we should just set it to a reasonably high value. I've defaulted it at 1MB which should be somewhere in the neighborhood of ~10 million metric names (with 100 character-long names) |
mleinart
added a commit
that referenced
this pull request
Aug 25, 2013
Add new type of cache query - 'cache-query-bulk'
mleinart
added a commit
that referenced
this pull request
Dec 6, 2013
Add new type of cache query - 'cache-query-bulk'
This was referenced Aug 10, 2014
jssjr
pushed a commit
to jssjr/carbon
that referenced
this pull request
Sep 30, 2014
Add new type of cache query - 'cache-query-bulk'
jssjr
pushed a commit
to jssjr/carbon
that referenced
this pull request
Sep 30, 2014
Add new type of cache query - 'cache-query-bulk'
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to query bulk of metrics in single request to Carbon