Optimized intersection of rollup job #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some metrics aka nodes took > 15 Minutes to process. There were over hundred thousand iterations over range(coarseArchive['retention']). Each iteration looped the entire list of overflowDatapoints - containing thousands of entries. Intention is to find intersections in time intervals. I added a primitive optimization. I compute the timestamp boundaries of overflowDatapoints before the big loop. Then I check the boundaries for intersection before overflowDatapoints is iterated. Now we can process ~3 nodes per Second.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some metrics / nodes took > 15 minutes for processing.
There were over hundred thousand iterations over range(coarseArchive['retention']).
Each iteration looped the entire list of overflowDatapoints - containing thousands of entries.
Intention is to find intersections in time intervals.
I added a primitive optimization:
I compute the timestamp boundaries of overflowDatapoints before the big loop.
Then I check the boundaries for intersection before overflowDatapoints is iterated.
Now we can process ~3 nodes per Second.