Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LICENSE file to pypi package #97

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Adding LICENSE file to pypi package #97

merged 1 commit into from
Apr 2, 2018

Conversation

deniszh
Copy link
Member

@deniszh deniszh commented Apr 1, 2018

Fixing #96

@koobs
Copy link

koobs commented Apr 1, 2018

@deniszh Thanks for this! It would be great if you could also add tests/*, tox.ini and requirements.txt, as setup.py doesn't yet use tests_require or document/implement running the tests (via test_suite, a test command or similar). This will help packagers run QA/tests downstream, hopefully resulting in additional feedback for yourself in the long term.

@deniszh
Copy link
Member Author

deniszh commented Apr 1, 2018

I'm not sure that test data should be included in pip package that way, sorry. If you want to build a package from the source - you should do it from source. Or please elaborate your use case, maybe I'm missing something.

@koobs
Copy link

koobs commented Apr 2, 2018

Including files via MANIFEST.in wont install them (not included in package_data), but will just include them in the sdist. sdists are as "from source" as repository sources are. Being able to QA sdists provided by upstreams via PyPI ensures quality of the entire upstream packaging pipeline can be tested, which benefits upstream projects as well as us.

@deniszh
Copy link
Member Author

deniszh commented Apr 2, 2018

@koobs
Could you please open a separate issue for that? I'll check what can be done.
Thanks!

@deniszh deniszh merged commit 4a25a31 into master Apr 2, 2018
@deniszh deniszh deleted the DZ-Pypi-LICENSE branch April 2, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants