Merge pull request #1071 from Kixeye/0.9.x-post

Use POST instead of GET for find and render requests (0.9.x)

webapp/graphite/local_settings.py.example

@@ -175,6 +175,7 @@
 #REMOTE_STORE_FETCH_TIMEOUT = 6   # Timeout to fetch series data
 #REMOTE_STORE_FIND_TIMEOUT = 2.5  # Timeout for metric find requests
 #REMOTE_STORE_RETRY_DELAY = 60    # Time before retrying a failed remote webapp
+#REMOTE_STORE_USE_POST = False    # Use POST instead of GET for remote requests
 #REMOTE_FIND_CACHE_DURATION = 300 # Time to cache remote metric find results
 
 ## Prefetch cache

webapp/graphite/remote_storage.py

@@ -60,7 +60,10 @@ def send(self):
     query_string = urlencode(query_params)
 
     try:
-      self.connection.request('GET', '/metrics/find/?' + query_string)
+      if settings.REMOTE_STORE_USE_POST:
+        self.connection.request('POST', '/metrics/find/', query_string)
+      else:
+        self.connection.request('GET', '/metrics/find/?' + query_string)
     except:
       self.store.fail()
       if not self.suppressErrors:
@@ -132,7 +135,10 @@ def fetch(self, startTime, endTime, now=None, result_queue=None):
 
     connection = HTTPConnectionWithTimeout(self.store.host)
     connection.timeout = settings.REMOTE_STORE_FETCH_TIMEOUT
-    connection.request('GET', '/render/?' + query_string)
+    if settings.REMOTE_STORE_USE_POST:
+      self.connection.request('POST', '/render/', query_string)
+    else:
+      self.connection.request('GET', '/render/?' + query_string)
     response = connection.getresponse()
     assert response.status == 200, "Failed to retrieve remote data: %d %s" % (response.status, response.reason)
     rawData = response.read()

webapp/graphite/settings.py

@@ -65,6 +65,7 @@
 REMOTE_STORE_FETCH_TIMEOUT = 6
 REMOTE_STORE_FIND_TIMEOUT = 2.5
 REMOTE_STORE_RETRY_DELAY = 60
+REMOTE_STORE_USE_POST = False
 REMOTE_FIND_CACHE_DURATION = 300
 REMOTE_PREFETCH_DATA = False