Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing bootstrapInterval for HoltWinters functions #1965

Merged
merged 2 commits into from
Jun 23, 2017
Merged

Introducing bootstrapInterval for HoltWinters functions #1965

merged 2 commits into from
Jun 23, 2017

Conversation

deniszh
Copy link
Member

@deniszh deniszh commented Jun 16, 2017

Default is '7d' - one week, as before. Format - same as for all others time intevals in Graphite.
Fixing #1957

Default is '7d' - one week, as before. Format - same as for all others time intevals in Graphite.
@codecov-io
Copy link

codecov-io commented Jun 16, 2017

Codecov Report

Merging #1965 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1965      +/-   ##
==========================================
+ Coverage   69.14%   69.14%   +<.01%     
==========================================
  Files          70       70              
  Lines        6954     6956       +2     
  Branches     1352     1352              
==========================================
+ Hits         4808     4810       +2     
  Misses       1912     1912              
  Partials      234      234
Impacted Files Coverage Δ
webapp/graphite/render/functions.py 89.83% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8908ea...79a9d5f. Read the comment docs.

Copy link
Member

@DanCech DanCech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. It doesn't support passing a bare number to mean "X intervals" like movingAverage does, but adding that would make things a fair bit more complicated for little gain imho. If we want to support that later I'd want to refactor the handling for that out into a separate helper we can share with movingAverage, etc.

@deniszh
Copy link
Member Author

deniszh commented Jun 16, 2017

Yes, agreed. Now all logic in HW bootstrap is based on seconds, so, decided to not put more complexity there, at least now.

@deniszh
Copy link
Member Author

deniszh commented Jun 23, 2017

It's fixing the issue, so, merging.

@deniszh deniszh merged commit 36ec377 into graphite-project:master Jun 23, 2017
@deniszh deniszh deleted the DZ-HW-bootstrapInterval branch June 23, 2017 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants