Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove most undefined variables issues in javascript files #2149

Merged
merged 2 commits into from Dec 6, 2017

Conversation

cbowman0
Copy link
Member

@cbowman0 cbowman0 commented Dec 6, 2017

Most were global variables defined in the templated html files or other included javascript files.
Others needed var/const declarations.

Only ones left are:

  2703:14  error  'ace' is not defined                                            no-undef
  2705:20  error  'require' is not defined                                        no-undef
  2802:19  error  'newURL' is not defined                                         no-undef
  2803:36  error  'newURL' is not defined                                         no-undef
  3333:55  error  'reset_params' is not defined                                   no-undef

Christopher Bowman added 2 commits December 6, 2017 09:04
Most were global variables defined in the templated html files or other included javascript files.
Others needed var/const declarations.
@codecov-io
Copy link

codecov-io commented Dec 6, 2017

Codecov Report

Merging #2149 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2149   +/-   ##
=======================================
  Coverage   77.96%   77.96%           
=======================================
  Files          80       80           
  Lines        8331     8331           
  Branches     1874     1874           
=======================================
  Hits         6495     6495           
  Misses       1573     1573           
  Partials      263      263

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7ae662...7f247c0. Read the comment docs.

@cbowman0 cbowman0 merged commit 1be03ab into graphite-project:master Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants