Swapping RGB <-> DarkRGB, replacing darkblue #2239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iksaif
approved these changes
Feb 21, 2018
DanCech
approved these changes
Feb 23, 2018
Civil
pushed a commit
to go-graphite/carbonapi
that referenced
this pull request
Feb 28, 2018
- Implement support for template argument for /render handler. Template file can be specified as graphTemplates parameter. It supports yaml and toml files, but not the 'ini' style conf - Make colors to look like in graphite-web in PR graphite-project/graphite-web#2239 - Allow to redefined default colors (see carbonapi.example.yaml/toml for examples) Fixes #163
|
The thing is that the "Fixed" colors are very hard to read on graphs. I think it'll be much better to redefined "dark" versions of colors and leave "normal" as-is. |
Keeping old colors as dark, fixing normal
|
let's close this then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #1310.
Red swapped with Darkred, Green with DarkGreen, Blue - with DarkBlue, and DarkBlue replaced with more suited
#002173Current colors:
Red: http://www.colorhexa.com/c80032
#c80032Green: http://www.colorhexa.com/00c800
#00c800Blue: http://www.colorhexa.com/6464ff
#6464ffDarkRed: http://www.colorhexa.com/ff0000
#ff0000DarkGreen: http://www.colorhexa.com/00ff00
#00ff00DarkBlue: http://www.colorhexa.com/0000ff
#0000ffFixed colors:
Red: http://www.colorhexa.com/ff0000
#ff0000Green: http://www.colorhexa.com/00ff00
#00ff00Blue: http://www.colorhexa.com/0000ff
#0000ffDarkRed: http://www.colorhexa.com/c80032
#c80032DarkGreen: http://www.colorhexa.com/00c800
#00c800DarkBlue: http://www.colorhexa.com/002173
#002173