Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent xss #2620

Merged
merged 8 commits into from
Jun 28, 2020
Merged

Prevent xss #2620

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3feadae
Sanitize dashboard name input to prevent XSS attack
StephenDsouza90 Jun 12, 2020
bd0d4cc
Added test case for sanitizing dashboard name
StephenDsouza90 Jun 14, 2020
53dbd30
Fix DeepSource failed checks
StephenDsouza90 Jun 14, 2020
6d7cd9d
Revert "Fix DeepSource failed checks"
StephenDsouza90 Jun 19, 2020
02ea677
Revert "Added test case for sanitizing dashboard name"
StephenDsouza90 Jun 19, 2020
ae82415
Revert "Sanitize dashboard name input to prevent XSS attack"
StephenDsouza90 Jun 19, 2020
e62ec5d
Use htmlEncode on dashboard name to prevent XSS
StephenDsouza90 Jun 19, 2020
7fa6a49
Update webapp/content/js/dashboard.js
StephenDsouza90 Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions webapp/content/js/dashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3015,8 +3015,8 @@ function setDashboardName(name) {

document.title = name + ' - Graphite Dashboard';
changeHash(name);
navBar.setTitle(name + ' - (' + dashboardURL + ')');
saveButton.setText('Save "' + name + '"');
navBar.setTitle(htmlEncode(name + ' - (' + dashboardURL + ')'));
saveButton.setText(htmlEncode('Save "' + name + '"'));
saveButton.enable();
}
}
Expand Down Expand Up @@ -3153,7 +3153,7 @@ function showDashboardFinder() {

dashboardsList = new Ext.list.ListView({
columns: [
{header: 'Dashboard', width: 1.0, dataIndex: 'name', sortable: false}
{header: 'Dashboard', width: 1.0, dataIndex: 'name', sortable: false, tpl:'{name:htmlEncode}'}
],
columnSort: false,
emptyText: 'No dashboards found',
Expand Down