Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding KEY_PREFIX parameter to set a memcached key prefix #714

Merged
merged 1 commit into from Sep 4, 2014

Conversation

g76r
Copy link
Contributor

@g76r g76r commented May 15, 2014

No description provided.

@@ -50,6 +50,7 @@
# unneeded cache misses. Set to [] to disable caching of images and fetched data
#MEMCACHE_HOSTS = ['10.10.10.10:11211', '10.10.10.11:11211', '10.10.10.12:11211']
#DEFAULT_CACHE_DURATION = 60 # Cache images and data for 1 minute
#KEY_PREFIX = ‘prefix’
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantic I know, but do you mind changing prefix to graphite?

@g76r
Copy link
Contributor Author

g76r commented Sep 4, 2014

@SEJeff right !

@obfuscurity
Copy link
Member

Seems like a reasonable change, but I'd like to see a better prefix name, e.g. MEMCACHE_KEY_PREFIX and also a brief mention in the configuration comments above.

P.S. This also needs to be rebased.

Adding the MEMCACHE_KEY_PREFIX parameter which can be overwritten by
local_settings.py so that each server using the same Django instance
can have a unique prefix for its caches
@g76r
Copy link
Contributor Author

g76r commented Sep 4, 2014

Rebased (and by the way squashed)

@obfuscurity obfuscurity changed the title adding KEY_PREFIX parameter to et a memcached key prefix adding KEY_PREFIX parameter to set a memcached key prefix Sep 4, 2014
@obfuscurity
Copy link
Member

Thanks!

obfuscurity added a commit that referenced this pull request Sep 4, 2014
adding KEY_PREFIX parameter to set a memcached key prefix
@obfuscurity obfuscurity merged commit 67d7b3f into graphite-project:master Sep 4, 2014
@SEJeff
Copy link
Member

SEJeff commented Sep 5, 2014

Legit

@g76r
Copy link
Contributor Author

g76r commented Sep 5, 2014

Thanks.

@g76r g76r deleted the f_keyprefix branch September 5, 2014 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants