Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make indentation consistent in files with mixed indentation #195

Merged
merged 1 commit into from
Feb 27, 2017

Conversation

piotr1212
Copy link
Member

I'm having trouble with my OCD by just looking at the files which mix indentation. Some files have a mix of two, four or even three spaces.

This patch sets the indentation to two spaces on all files with mixed indentation. This is just aesthetic It should not change any logic. I didn't touch the files which have a consistent four space indentation.

I would rather update everything to 4 spaces to comply with pep8 and add flake8 test, but don't know if that will get merged as that would change almost every line of code.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.291% when pulling 99a4030 on piotr1212:indentation into 4f2d2ac on graphite-project:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.291% when pulling 99a4030 on piotr1212:indentation into 4f2d2ac on graphite-project:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.291% when pulling 99a4030 on piotr1212:indentation into 4f2d2ac on graphite-project:master.

@deniszh
Copy link
Member

deniszh commented Feb 27, 2017

I'm fine with that. Not sure if we need to migrate to 4 spaces, though.

@deniszh deniszh merged commit b783ab3 into graphite-project:master Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants