whisper-fill.py: python3 compatiblity with itertools #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniszh
reviewed
May 8, 2017
bin/whisper-fill.py
Outdated
| import time | ||
| import sys | ||
| import optparse | ||
|
|
||
| if sys.version_info >= (3, 0): | ||
| xrange = range | ||
| else: | ||
| from future_builtins import filter |
There was a problem hiding this comment.
Not 100% sure if it is needed in this specific case. But I've added it to be sure we get same behaviour in all version.
3 similar comments
|
I have no clue why the travis test fails, seems to work fine locally. |
|
Test went fine after restart, Codacy also can be ignored in this case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address issues mentioned in #190