Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 #213

Merged
merged 27 commits into from
May 8, 2017
Merged

Flake8 #213

merged 27 commits into from
May 8, 2017

Conversation

piotr1212
Copy link
Member

style cleanup

./setup.py:3:1: F401 'os' imported but unused
./contrib/whisper-auto-resize.py:77:5: F401 'carbon.conf' imported but unused
./bin/whisper-diff.py:4:1: F401 'time' imported but unused
./bin/whisper-resize.py:5:1: F401 'math' imported but unused
./bin/whisper-set-aggregation-method.py:3:1: F401 'os' imported but unused
missing whitespace after ','
E302 expected 2 blank lines, found 1
E226 missing whitespace around arithmetic operator
E201 whitespace after '('
E203 whitespace before ':'
E265 block comment should start with '# '
E228 missing whitespace around modulo operator
F841 local variable '' is assigned to but never used
E712 comparison to True should be 'if cond is True:' or 'if cond:'
W291 trailing whitespace
E221 multiple spaces before operator
E501 line too long
E222 multiple spaces after operator
E222 multiple spaces after operator
E261 at least two spaces before inline comment
E401 multiple imports on one line
E402 module level import not at top of file
E701 multiple statements on one line (colon)
F821 undefined name 'errno'
W391 blank line at end of file
E202 whitespace before ')'
E128 continuation line under-indented for visual indent
E127 continuation line over-indented for visual indent
E731 do not assign a lambda expression, use a def
E114 indentation is not a multiple of four (comment)
@coveralls
Copy link

coveralls commented May 8, 2017

Coverage Status

Coverage decreased (-0.3%) to 88.3% when pulling b387ace on piotr1212:flake8 into 0d5a0de on graphite-project:master.

@deniszh
Copy link
Member

deniszh commented May 8, 2017

Wow ! What a huge effort!
Looks good, thanks!

@deniszh deniszh merged commit eafbc03 into graphite-project:master May 8, 2017
@piotr1212 piotr1212 deleted the flake8 branch May 8, 2017 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants