Switch to setuptools #272
Merged
Switch to setuptools #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes warnings UserWarning: Unknown distribution option: 'install_requires' UserWarning: Unknown distribution option: 'long_description_content_type' setuptools seems to be the recommended way now.
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
=======================================
Coverage 87.96% 87.96%
=======================================
Files 2 2
Lines 1113 1113
Branches 156 156
=======================================
Hits 979 979
Misses 94 94
Partials 40 40Continue to review full report at Codecov.
|
deniszh
approved these changes
Jan 7, 2019
|
👍 |
|
We can also revert that pesky |
|
So I found out that setup tools has issues with the prefix.... I wanted to
propose to get rid of it, but needed some time to argument it properly
because I expect some "it has worked like this for 10 years" backlash.
…On Mon, 7 Jan 2019, 23:18 Denis Zhdanov ***@***.*** wrote:
We can also revert that pesky GRAPHITE_NO_PREFIX=True logic too... not
directly related, though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#272 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACxrWvm3v63w8--I_-3akMHlarILBjJpks5vA8e8gaJpZM4Z0WFY>
.
|
|
This one can already be merged, still writing docs and testing for carbon and web. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes warnings
UserWarning: Unknown distribution option: 'install_requires'
UserWarning: Unknown distribution option: 'long_description_content_type'
setuptools seems to be the recommended way now.